metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request #107: METAMODEL-1093 close compiled ResultSets
Date Fri, 03 Jun 2016 20:35:42 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/107#discussion_r65771496
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataSet.java ---
    @@ -197,8 +197,12 @@ public void close() {
             if (_closed) {
                 return;
             }
    +
    +        FileHelper.safeClose(_resultSet);
    +
             if (_jdbcDataContext != null) {
    -            _jdbcDataContext.close(_connection, _resultSet, _statement);
    +            FileHelper.safeClose(_statement);
    --- End diff --
    
    No, we can't close the statement unconditionally, it makes almost every single test fail.
I'm not entirely sure why (didn't really pursue it, honestly).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message