Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C36E2009D9 for ; Mon, 2 May 2016 22:08:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3AE261609B1; Mon, 2 May 2016 22:08:33 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D10F1602C5 for ; Mon, 2 May 2016 22:08:32 +0200 (CEST) Received: (qmail 71015 invoked by uid 500); 2 May 2016 20:08:31 -0000 Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.apache.org Delivered-To: mailing list dev@metamodel.apache.org Received: (qmail 70973 invoked by uid 99); 2 May 2016 20:08:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 20:08:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9652E2B48F7; Mon, 2 May 2016 20:08:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8709190526922715351==" MIME-Version: 1.0 Subject: Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses methods to create HBase and POJO data contexts From: Sagar Gandhi To: Sagar Gandhi , Tomasz Guzialek , MetaModel Date: Mon, 02 May 2016 20:08:25 -0000 Message-ID: <20160502200825.19046.26368@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sagar Gandhi X-ReviewGroup: MetaModel X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46902/ X-Sender: Sagar Gandhi References: <20160502195116.19046.15908@reviews.apache.org> In-Reply-To: <20160502195116.19046.15908@reviews.apache.org> Reply-To: Sagar Gandhi X-ReviewRequest-Repository: metamodel archived-at: Mon, 02 May 2016 20:08:33 -0000 --===============8709190526922715351== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 2, 2016, 7:51 p.m., Tomasz Guzialek wrote: > > full/src/main/java/org/apache/metamodel/DataContextFactory.java, line 765 > > > > > > Shouldn't that be a "List> tables" as parameter? Pojo data context have 2 constructors , one with List> tables and other with TableDataProvider... tableProviders. for List> parameterized constructor , We have already added a method. for TableDataProvider... tableProviders we have changed it to array instead of list. Thanks for pointing it out. New diff is added. Please review it. - Sagar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46902/#review131361 ----------------------------------------------------------- On May 2, 2016, 8:05 p.m., Sagar Gandhi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46902/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 8:05 p.m.) > > > Review request for MetaModel. > > > Repository: metamodel > > > Description > ------- > > Bug Description : > Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext. > > Solution : > Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors. > > > Diffs > ----- > > full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2 > > Diff: https://reviews.apache.org/r/46902/diff/ > > > Testing > ------- > > > Thanks, > > Sagar Gandhi > > --===============8709190526922715351==--