metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sagar Gandhi <gandhi.sa...@live.com>
Subject Review Request 48005: Salesforce feature requests
Date Sat, 28 May 2016 08:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48005/
-----------------------------------------------------------

Review request for MetaModel.


Repository: metamodel


Description
-------

Feature Requests

1. Constructor which takes connection from calling program for hybrid Models.
2. Return the connection instance outside for hybrid model.


Changes done 
1. Added constructor which takes PartnerConnection as argument.
2. Added getter method for ParterConnection

Open Questions
1. Currently I have validated the input PartenerConnection for null value. Do we also need
to check if connection is alive or not ? . If given input connection is already logged out
then the further operations may fail with exception. There is a similar situation in JDBCDataContext
which takes Connection as in parameter, but in JDBCContext we are performing operation on
input connection  in constructor only. So if connection is already closed then constructor
only logs the exception to warn or debug level.  It does not throw exception.


Diffs
-----

  salesforce/src/main/java/org/apache/metamodel/salesforce/SalesforceDataContext.java c8add52


Diff: https://reviews.apache.org/r/48005/diff/


Testing
-------


Thanks,

Sagar Gandhi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message