metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: FixedWidth EBCDIC support
Date Fri, 20 May 2016 12:01:16 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/103#discussion_r64030531
  
    --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
    @@ -54,45 +56,49 @@ public FixedWidthConfiguration(int fixedValueWidth) {
     	}
     
     	public FixedWidthConfiguration(int[] valueWidth) {
    -		this(DEFAULT_COLUMN_NAME_LINE, FileHelper.DEFAULT_ENCODING, valueWidth,
    -				false);
    +		this(DEFAULT_COLUMN_NAME_LINE, FileHelper.DEFAULT_ENCODING, valueWidth, false, false,
true);
     	}
     
         public FixedWidthConfiguration(int columnNameLineNumber, String encoding, int fixedValueWidth)
{
    -        this(columnNameLineNumber, encoding, fixedValueWidth, false);
    +        this(columnNameLineNumber, encoding, fixedValueWidth, false, false, true);
         }
     
         public FixedWidthConfiguration(int columnNameLineNumber, String encoding, int fixedValueWidth,
    -            boolean failOnInconsistentLineWidth) {
    +            boolean failOnInconsistentLineWidth, boolean headerPresent, boolean eolPresent)
{
             this.encoding = encoding;
             this.fixedValueWidth = fixedValueWidth;
             this.columnNameLineNumber = columnNameLineNumber;
             this.failOnInconsistentLineWidth = failOnInconsistentLineWidth;
    +		this.headerPresent = headerPresent;
    +		this.eolPresent = eolPresent;
    --- End diff --
    
    Something weird happening with the whitespace here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message