metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sagar Gandhi <gandhi.sa...@live.com>
Subject Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses methods to create HBase and POJO data contexts
Date Mon, 02 May 2016 20:08:25 GMT


> On May 2, 2016, 7:51 p.m., Tomasz Guzialek wrote:
> > full/src/main/java/org/apache/metamodel/DataContextFactory.java, line 765
> > <https://reviews.apache.org/r/46902/diff/1/?file=1369020#file1369020line765>
> >
> >     Shouldn't that be a "List<TableDataProvider<?>> tables" as parameter?

Pojo data context have 2 constructors , one with List<TableDataProvider<?>> tables
and other with TableDataProvider... tableProviders.  for List<TableDataProvider<?>>
parameterized constructor , We have already added a method. for TableDataProvider... tableProviders
we have changed it to array instead of list. 

Thanks for pointing it out.  New diff is added. Please review it.


- Sagar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/#review131361
-----------------------------------------------------------


On May 2, 2016, 8:05 p.m., Sagar Gandhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46902/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 8:05 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> Bug Description :
> Every DataContext implementation is represented in the DataContextFactory with a method
for creating such DataContext. However, there are no methods for creating HBaseDataContext
and PojoDataContext.
> 
> Solution :
> Created methods for HBase and Pojo. Added different overloaded methods for overloaded
constructors.
> 
> 
> Diffs
> -----
> 
>   full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2 
> 
> Diff: https://reviews.apache.org/r/46902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sagar Gandhi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message