metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns
Date Tue, 26 Apr 2016 12:12:12 GMT

    [ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257967#comment-15257967
] 

ASF GitHub Bot commented on METAMODEL-244:
------------------------------------------

Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/96#discussion_r61074112
  
    --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/DefaultColumnNamingStrategy.java
---
    @@ -0,0 +1,35 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.metamodel.schema.naming;
    +
    +import org.apache.metamodel.schema.builder.DelegatingIntrinsicSwitchColumnNamingStrategy;
    +
    +/**
    + * The default (in most cases) {@link ColumnNamingStrategy} to use when no other
    + * strategy is specified.
    + */
    +public class DefaultColumnNamingStrategy extends DelegatingIntrinsicSwitchColumnNamingStrategy
{
    --- End diff --
    
    (repeat of #97 comment, just in the right place :))
    That's a pretty weird way to make something a default to me.
    
    This screams for some sort of proper factory.


> Ability to specify column names for datastores that may not have named columns
> ------------------------------------------------------------------------------
>
>                 Key: METAMODEL-244
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-244
>             Project: Apache MetaModel
>          Issue Type: New Feature
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>
> Some datastores don't necesarily define the column names/headers, just the data. Therefore
it is sometimes needed to define column names manually - or even via some pluggable interface
that would allow a custom naming strategy.
> I can think of the following modules where this would be relevant:
>  * csv
>  * fixed-width
>  * excel



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message