metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...
Date Wed, 27 Apr 2016 02:31:16 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/98#discussion_r61195959
  
    --- Diff: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
---
    @@ -78,15 +86,15 @@ public static QueryBuilder getExistsQuery(String fieldName) {
             return getFilteredQuery("exists", fieldName);
         }
     
    -    public static List<Object> getSourceProperties(final MutableTable table) {
    +    public static Object getMappingSource(final MutableTable table) {
    --- End diff --
    
    Hmm I chose for Object because I felt that the data type was irrelevant - or even an implementation
detail. The 'source' object is some kind of magical object anyway without much type safety.
But on the other hand, it seems that the `source(Map)` method is different in behaviour from
`source(Object)` so that's a good case for changing this method to return map.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message