metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: Added new aggregate functions FIRST, LAST,...
Date Sun, 06 Dec 2015 16:05:27 GMT
Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/74#issuecomment-162326084
  
    LGTM, but I'm really no fan of reformatting an entire file unless we touch much of the
file. It makes reviews much harder than they need to be, and destroys history.
    
    I'd suggest we keep our hands off the reformat shortcut without selecting an area around
our edits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message