metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kasper Sørensen <i.am.kasper.soren...@gmail.com>
Subject Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel
Date Mon, 09 Nov 2015 18:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105708
-----------------------------------------------------------



excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java (line 48)
<https://reviews.apache.org/r/40074/#comment164320>

    I notice here that the indentation is tab-based whereas the rest is using spaces.


- Kasper Sørensen


On nov. 9, 2015, 10:03 a.m., Sai Krishna Kishore Beathanabhotla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
> 
> (Updated nov. 9, 2015, 10:03 a.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> Added validation to check for invalid characters and sheetname length for excel
> 
> 
> Diffs
> -----
> 
>   excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89 
>   excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd

> 
> Diff: https://reviews.apache.org/r/40074/diff/
> 
> 
> Testing
> -------
> 
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
> 
> 
> Thanks,
> 
> Sai Krishna Kishore Beathanabhotla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message