metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: METAMODEL-204: Fixed
Date Tue, 27 Oct 2015 08:32:55 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/66#discussion_r43093927
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java
---
    @@ -280,6 +280,12 @@ protected String rewriteSelectClause(Query query, SelectClause selectClause)
{
         }
     
         protected String rewriteSelectItem(Query query, SelectItem item) {
    +        if (item.isFunctionApproximationAllowed()) {
    +            // function approximation is not included in any standard SQL
    +            // constructions - will have to be overridden by subclasses if there
    +            // are specialized dialects for it.
    +            item = item.replaceFunctionApproximationAllowed(false);
    +        }
    --- End diff --
    
    Nope, it's removing it, so that it doesn't end up in end at i.e. JDBC contexts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message