metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: Support for Max Rows / Limit = 0
Date Thu, 08 Oct 2015 07:29:06 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/57#discussion_r41483137
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java ---
    @@ -336,6 +336,13 @@ public DataSet executeQuery(CompiledQuery compiledQuery, Object...
values) {
     
         private DataSet execute(Connection connection, Query query, Statement statement,
JdbcCompiledQuery compiledQuery,
                 JdbcCompiledQueryLease lease, Object[] values) throws SQLException, MetaModelException
{
    +        Integer maxRows = query.getMaxRows();
    +
    +        final List<SelectItem> selectItems = query.getSelectClause().getItems();
    +        if (maxRows != null && maxRows.intValue() == 0) {
    --- End diff --
    
    Then the next guy doesn't try to understand the code he is changing, and shouldn't be
allowed near it ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message