metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <>
Subject [GitHub] metamodel pull request: Support for Max Rows / Limit = 0
Date Thu, 08 Oct 2015 07:23:36 GMT
Github user kaspersorensen commented on a diff in the pull request:
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/ ---
    @@ -336,6 +336,13 @@ public DataSet executeQuery(CompiledQuery compiledQuery, Object...
values) {
         private DataSet execute(Connection connection, Query query, Statement statement,
JdbcCompiledQuery compiledQuery,
                 JdbcCompiledQueryLease lease, Object[] values) throws SQLException, MetaModelException
    +        Integer maxRows = query.getMaxRows();
    --- End diff --
    Nope, it mutates later on in the method. Line 390.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message