Return-Path: X-Original-To: apmail-metamodel-dev-archive@minotaur.apache.org Delivered-To: apmail-metamodel-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 080D618795 for ; Thu, 3 Sep 2015 13:43:53 +0000 (UTC) Received: (qmail 2126 invoked by uid 500); 3 Sep 2015 13:43:46 -0000 Delivered-To: apmail-metamodel-dev-archive@metamodel.apache.org Received: (qmail 2094 invoked by uid 500); 3 Sep 2015 13:43:46 -0000 Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.apache.org Delivered-To: mailing list dev@metamodel.apache.org Received: (qmail 2080 invoked by uid 99); 3 Sep 2015 13:43:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2015 13:43:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 09F70DFF70; Thu, 3 Sep 2015 13:43:46 +0000 (UTC) From: LosD To: dev@metamodel.apache.org Reply-To: dev@metamodel.apache.org Message-ID: Subject: [GitHub] metamodel pull request: Use missing and exists filters for null co... Content-Type: text/plain Date: Thu, 3 Sep 2015 13:43:46 +0000 (UTC) GitHub user LosD opened a pull request: https://github.com/apache/metamodel/pull/48 Use missing and exists filters for null comparisons. This will make isNull() and isNotNull() work. They failed before, as a term query, which does not support null values, was used. A test was also un-ignored; It was ignored as it used to fail, but the fix for METAMODEL-172 fixed the test as well. Fixes METAMODEL-184 You can merge this pull request into a Git repository by running: $ git pull https://github.com/LosD/metamodel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metamodel/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 ---- commit 053c34684f6f46948bc3ad3a71a5a366ac9526f8 Author: Dennis Du Krøger Date: 2015-09-03T13:41:44Z Use missing and exists filters for null comparisons. This will make isNull() and isNotNull() work. They failed before, as a term query, which does not support null values, was used. A test was also un-ignored; It was ignored as it used to fail, but the fix for METAMODEL-172 fixed the test as well. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---