metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: Use missing and exists filters for null co...
Date Thu, 03 Sep 2015 13:43:46 GMT
GitHub user LosD opened a pull request:

    https://github.com/apache/metamodel/pull/48

    Use missing and exists filters for null comparisons.

    This will make isNull() and isNotNull() work. They failed before, as a term query, which
does not support null values, was used. A test was also un-ignored; It was ignored as it used
to fail, but the fix  for METAMODEL-172 fixed the test as well.
    
    Fixes METAMODEL-184

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LosD/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit 053c34684f6f46948bc3ad3a71a5a366ac9526f8
Author: Dennis Du Kr√łger <dennis.dukroger@humaninference.com>
Date:   2015-09-03T13:41:44Z

    Use missing and exists filters for null comparisons.
    
    This will make isNull() and isNotNull() work. They failed before, as a
     term query, which does not support null values, was used. A test was
      also un-ignored; It was ignored as it used to fail, but the fix
      for METAMODEL-172 fixed the test as well.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message