metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Du Krøger (JIRA) <j...@apache.org>
Subject [jira] [Updated] (METAMODEL-187) ExcelDataContext uses more memory than it needs to for File-based resources.
Date Tue, 08 Sep 2015 13:51:46 GMT

     [ https://issues.apache.org/jira/browse/METAMODEL-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dennis Du Krøger updated METAMODEL-187:
---------------------------------------
    Attachment: Memory use File-based.png
                Memory use InputStream-based.png

Attached JVisualVM screenshots.

> ExcelDataContext uses more memory than it needs to for File-based resources.
> ----------------------------------------------------------------------------
>
>                 Key: METAMODEL-187
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-187
>             Project: Apache MetaModel
>          Issue Type: Bug
>            Reporter: Dennis Du Krøger
>            Priority: Minor
>         Attachments: Memory use File-based.png, Memory use InputStream-based.png
>
>
> ExcelDataContext uses the input stream from resources, even if it is a FileResource.
This is pretty wasteful memory-wise, both according to http://poi.apache.org/spreadsheet/quick-guide.html#FileInputStream
and to own tests; I made a naïve change that uses the internal File of FileResources on a
huge file. With InputStream, getting the defaultSchema used around 950 MB in average, while
it used around 650 in average with the File based version (nothing scientific, just eyeballed
in JVisualVM).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message