metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Use missing and exists filters for null co...
Date Thu, 03 Sep 2015 13:47:28 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/48#discussion_r38646827
  
    --- Diff: elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java
---
    @@ -559,7 +560,16 @@ private static void indexBulkDocuments(String indexName, String indexType,
int n
     
         }
     
    -    private static void indexOneTweeterDocumentPerIndex(String indexType, int id) {
    +    private static void indexTweeterDocument(String indexType, int id, Date date) {
    +        try {
    +            client.prepareIndex(indexName, indexType).setSource(buildTweeterJson(id,
date))
    +                    .setId("tweet_" + indexType + "_" + id).execute().actionGet();
    +        } catch (Exception ex) {
    +            System.out.println("Exception indexing documents!!!!!");
    --- End diff --
    
    Wouldn't a rethrow be better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message