metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Refactoring to support scalar function
Date Sun, 09 Aug 2015 22:41:54 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/34#discussion_r36594696
  
    --- Diff: core/src/main/java/org/apache/metamodel/query/FunctionTypeFactory.java ---
    @@ -0,0 +1,43 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.metamodel.query;
    +
    +/**
    + * Factory to create AggregateFunctions through
    + * its function name.
    + *
    + */
    +public class FunctionTypeFactory {
    +
    +    public static AggregateFunction get(String functionName) {
    +        if (functionName.equals("COUNT")) {
    +            return new CountAggregateFunction();
    +        } else if (functionName.equals("AVG")) {
    +            return new AverageAggregateFunction();
    +        } else if (functionName.equals("SUM")) {
    +            return new SumAggregateFunction();
    +        } else if (functionName.equals("MAX")) {
    +            return new MaxAggregateFunction();
    +        } else if (functionName.equals("MIN")) {
    +            return new MinAggregateFunction();
    --- End diff --
    
    I guess it would be nicer to just return the single instances that we know from FunctionType.MIN,
FunctionType.COUNT here etc...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message