metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Refactoring to support scalar function
Date Wed, 29 Jul 2015 06:37:02 GMT
Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/34#issuecomment-125858077
  
    Looking at the Function and FunctionType interface I see too much overlap IMO. And methods
like build and evaluate seem to only apply to aggregations. So maybe delete the new Function
interface? And move methods to AggregateFunction interface? 
    
    Sorry for the very short remarks. On worst Internet connection ever.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message