metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kasper Sørensen <i.am.kasper.soren...@gmail.com>
Subject Re: Review Request 35123: METAMODEL-148: Created a HdfsResource
Date Wed, 10 Jun 2015 11:04:17 GMT


> On juni 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java, line 25
> > <https://reviews.apache.org/r/35123/diff/2/?file=979936#file979936line25>
> >
> >     We could think about a default port number.

I would like that, but having trouble figuring out what the default actually is. According
to this page [1] the default is 8200. But according to the Apache Hadoop documentation [2]
it should be set up normally to run on port 9000. So maybe 9000 is a defacto standard while
8200 is the true default. I am not sure, so it's hard for me to judge.

[1] http://blog.cloudera.com/blog/2009/08/hadoop-default-ports-quick-reference
[2] http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/SingleCluster.html


- Kasper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On juni 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated juni 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the
hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from
a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation
warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message