metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Fresh PR for Sor
Date Wed, 20 May 2015 20:07:12 GMT
Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/19#issuecomment-104020116
  
    A couple of remarks on code style:
    
     * In eclipse I see a bunch of warnings that should be fixed:
      * Unused variables (multiple)
      * Unused imports (multiple)
      * Deprecated classes (DefaultHttpClient)
      * Use of raw type generics (multiple)
      * Resource leak: HttpClient is never used
     * Unstandard naming: QUERYTYPE is entirely uppercase, should be QueryType
     * For me to read a very inconsistent use of "this" keyword and instance variables - difficult
state management especially in the dataset class.
    
    Bringing these items to order is for me a prerequisite for doing a proper review because
readability isn't very good as long as I have to deal with so many warnings etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message