metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Metamodel 133
Date Mon, 04 May 2015 17:31:43 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/20#discussion_r29604117
  
    --- Diff: core/src/main/java/org/apache/metamodel/query/FromItem.java ---
    @@ -267,6 +267,11 @@ private void appendJoinOnItem(StringBuilder sb, String sideAlias,
SelectItem onI
                 sb.append(superQueryAlias);
                 return;
             }
    +        
    +        if(_join != null && _leftSide.getJoin() != null) {
    --- End diff --
    
    And actually this trick avoids/skips the sideAlias thing ... might be a bit too destructive.
Do we _need_ to avoid the parenthesis or is it just cosmetic?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message