metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: Metamodel 133
Date Mon, 04 May 2015 17:23:26 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/20#discussion_r29603317
  
    --- Diff: core/src/main/java/org/apache/metamodel/query/parser/FromItemParser.java ---
    @@ -66,7 +71,11 @@ public void parse(String delim, String itemToken) {
                     fromItem.setAlias(alias);
                 }
             } else if (itemToken.toUpperCase().indexOf(" JOIN ") != -1) {
    -            fromItem = parseJoinItem(itemToken);
    +            if(itemToken.split("(?i) JOIN ").length == 2) {
    --- End diff --
    
    I'm thinking that instead of splitting this text twice (here and in parseAllJoinItems)
then wouldn't it be better to not have this if-block and just always apply parseAllJoinItems(...)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message