metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Date Wed, 29 Apr 2015 09:03:30 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/21#discussion_r29319785
  
    --- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
    @@ -435,6 +442,19 @@ private String getOperatorName(FilterItem item) {
             return operatorName;
         }
     
    +    private Pattern turnOperandIntoRegExp(Object operand) {
    +        String operandAsString = operand.toString();
    +        StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
    +        if (!operandAsString.startsWith("%") && operandAsString.contains("%"))
{
    +            operandAsRegExp = operandAsRegExp.insert(0, "^");
    +        }
    +        return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
    +    }
    --- End diff --
    
    Isn't this missing the ```LIKE '%xxxxxx'``` case? I'd imagine a regex with $ in the end
in that case, so that ```xxxxxxy``` wouldn't match, while ```yxxxxxx``` would.
    
    But do we even need all these special cases? I would guess that always adding ^ and $
would always make it work? A few examples:
    ```LIKE 'xxxxxx'``` would become ```/^xxxxxxx$/``` which would only match ```xxxxxx```.
    ```LIKE '%xxxxxx'``` would become ```/^.*xxxxxx$/``` which would match anything ending
with ```xxxxxx```.
    ```LIKE 'xxxxxx%'``` would become ```/^xxxxxx.*$/``` which would match anything starting
with ```xxxxxx```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message