metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request: changing select(expression) method of Quer...
Date Thu, 26 Mar 2015 19:17:04 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/11#discussion_r27246435
  
    --- Diff: core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java
---
    @@ -1022,4 +1022,16 @@ public void testQueryWithDotInTableName() throws Exception {
     
             assertEquals("file.csv.foo = 'bar'", item.toSql());
         }
    +    
    +    public void testQueryWithMultipleColumnsInExpression() {
    +        Query query1 = new Query().from(table1).select("contributor_id,name");
    +        DataSet set = getDataContext().executeQuery(query1);
    +        assertEquals(set.next(), true);
    +        assertEquals(set.getRow().toString(), "Row[values=[1, kasper]]");
    --- End diff --
    
    Not that it matters much, but I am pretty sure that "expected" and "actual" parameters
are switched around here. Normally you have expectation as the first argument.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message