metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kasper Sørensen <i.am.kasper.soren...@gmail.com>
Subject Re: Review Request 32310: Removes ElasticSearch 1.4.x-incompatible getHeaders()
Date Sat, 21 Mar 2015 15:29:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32310/#review77340
-----------------------------------------------------------

Ship it!


Ship It!

- Kasper Sørensen


On marts 20, 2015, 4:07 p.m., Dennis Krøger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32310/
> -----------------------------------------------------------
> 
> (Updated marts 20, 2015, 4:07 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> ES 1.4.x has changed the return value of TransportMessage#getHeaders to a Set. As we
only use the code for debugging in a single builder, my solution has been to just remove the
headers from the delete message.
> 
> 
> Diffs
> -----
> 
>   elasticsearch/pom.xml 94b36bd 
>   elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDeleteBuilder.java
3aae761 
> 
> Diff: https://reviews.apache.org/r/32310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis Krøger
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message