Return-Path: X-Original-To: apmail-metamodel-dev-archive@minotaur.apache.org Delivered-To: apmail-metamodel-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74CF9109D2 for ; Fri, 5 Dec 2014 08:37:02 +0000 (UTC) Received: (qmail 16200 invoked by uid 500); 5 Dec 2014 08:37:02 -0000 Delivered-To: apmail-metamodel-dev-archive@metamodel.apache.org Received: (qmail 16169 invoked by uid 500); 5 Dec 2014 08:37:02 -0000 Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.apache.org Delivered-To: mailing list dev@metamodel.apache.org Received: (qmail 16145 invoked by uid 99); 5 Dec 2014 08:37:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 08:37:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4BAA31D210D; Fri, 5 Dec 2014 08:36:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6941578751176622889==" MIME-Version: 1.0 Subject: Re: Review Request 28707: METAMODEL-100: Fixed comparison of columns based on col number From: "Tomasz Guzialek" To: Tomasz Guzialek , MetaModel , =?utf-8?q?Kasper_S=C3=B8rensen?= Date: Fri, 05 Dec 2014 08:36:58 -0000 Message-ID: <20141205083658.32525.28594@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tomasz Guzialek" X-ReviewGroup: MetaModel X-ReviewRequest-URL: https://reviews.apache.org/r/28707/ X-Sender: "Tomasz Guzialek" References: <20141204184606.32525.48671@reviews.apache.org> In-Reply-To: <20141204184606.32525.48671@reviews.apache.org> Reply-To: "Tomasz Guzialek" X-ReviewRequest-Repository: metamodel --===============6941578751176622889== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28707/#review63978 ----------------------------------------------------------- Ship it! Ship It! - Tomasz Guzialek On Dec. 4, 2014, 6:46 p.m., Kasper Sørensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28707/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:46 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-100 > https://issues.apache.org/jira/browse/METAMODEL-100 > > > Repository: metamodel > > > Description > ------- > > My proposed fix for METAMODEL-100 > > > Diffs > ----- > > core/src/main/java/org/apache/metamodel/schema/AbstractColumn.java 8f276f5 > core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java 3b2be2f > > Diff: https://reviews.apache.org/r/28707/diff/ > > > Testing > ------- > > Unittest added to show the issue. > > > Thanks, > > Kasper Sørensen > > --===============6941578751176622889==--