Mailing-List: contact dev-help@metamodel.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@metamodel.incubator.apache.org
From: albertostratio <git@git.apache.org>
To: dev@metamodel.incubator.apache.org
Reply-To: dev@metamodel.incubator.apache.org
References: <git-pr-2-incubator-metamodel@git.apache.org>
In-Reply-To: <git-pr-2-incubator-metamodel@git.apache.org>
Subject: [GitHub] incubator-metamodel pull request: Cassandra DB support for
 MetaMod...
Content-Type: text/plain
Message-Id: <20141003065546.A986BA1ECB4@tyr.zones.apache.org>
Date: Fri,  3 Oct 2014 06:55:46 +0000 (UTC)

Github user albertostratio commented on a diff in the pull request:

    https://github.com/apache/incubator-metamodel/pull/2#discussion_r18383384
  
    --- Diff: full/src/main/java/org/apache/metamodel/DataContextFactory.java ---
    @@ -649,4 +651,16 @@ public static UpdateableDataContext createCouchDbDataContext(String hostname, In
         public static QueryPostprocessDataContext createElasticSearchDataContext(Client client, String indexName) {
             return new ElasticSearchDataContext(client, indexName);
         }
    +
    +    /**
    +     * Creates a new Cassandra datacontext.
    +     * @param cluster
    +     *       The Cassandra client
    +     * @param keySpaceName
    +     *       The Cassandra key space name
    +     * @return a DataContext object that matches the request
    +     */
    +    public static QueryPostprocessDataContext createCassandraDataContext(Cluster cluster, String keySpaceName) {
    --- End diff --
    
    Another good point. I have also modified the createElasticSearchDataContext that was returning also a QueryPostprocessDataContext


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---