metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alberto Rodriguez <arodrig...@stratio.com>
Subject Re: Review Request 26909: METAMODEL-84: Use ElasticSearch doc id as Primary Key
Date Tue, 21 Oct 2014 14:34:15 GMT
Hi Kasper,

Your changes look fine to me, just one question: you are now adding the
FIELD_ID within the metadata... is that consistent with the other modules?
For instance, for the Mongo connector are we also adding the objectid
within the metadata?

Kind regards,


Alberto Rodríguez


<http://www.stratio.com/>
Avenida de Europa, 26. Ática 5. 3ª Planta
28224 Pozuelo de Alarcón, Madrid
Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>*

2014-10-21 13:48 GMT+02:00 Kasper Sørensen <i.am.kasper.sorensen@gmail.com>:

> Anyone wants to give a review for this? Or else I will push it as per lazy
> concensus.
>
> 2014-10-19 12:30 GMT+02:00 Kasper Sørensen <i.am.kasper.sorensen@gmail.com
> >:
>
> >    This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/26909/
> >   Review request for MetaModel.
> > By Kasper Sørensen.
> >
> > *Updated okt. 19, 2014, 10:30 a.m.*
> >  *Bugs: * METAMODEL-84
> > <https://issues.apache.org/jira/browse/METAMODEL-84>
> >  *Repository: * metamodel
> > Description
> >
> > My proposed fix for METAMODEL-84
> >
> >   Testing (updated)
> >
> > Added unittests.
> >
> > Also accidentally encountered a (unrelated) issue with date values in
> ElasticSearch. Added a reproduction unittest with @Ignore (so that it would
> not block this work). Reported this other issue here:
> https://issues.apache.org/jira/browse/METAMODEL-87
> >
> >   Diffs
> >
> >    -
> elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContext.java
> >    (a7b00c9)
> >    -
> elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataSet.java
> >    (c7e5fe9)
> >    -
> elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchMetaDataParser.java
> >    (04991fe)
> >    -
> elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchUtils.java
> >    (PRE-CREATION)
> >    -
> elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java
> >    (d1794fc)
> >    -
> elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchMetaDataParserTest.java
> >    (d7e62e6)
> >
> > View Diff <https://reviews.apache.org/r/26909/diff/>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message