metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kasper Sørensen <i.am.kasper.soren...@gmail.com>
Subject Re: Review Request 26909: METAMODEL-84: Use ElasticSearch doc id as Primary Key
Date Sun, 19 Oct 2014 10:30:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26909/
-----------------------------------------------------------

(Updated okt. 19, 2014, 10:30 a.m.)


Review request for MetaModel.


Bugs: METAMODEL-84
    https://issues.apache.org/jira/browse/METAMODEL-84


Repository: metamodel


Description
-------

My proposed fix for METAMODEL-84


Diffs
-----

  elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContext.java
a7b00c9 
  elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataSet.java
c7e5fe9 
  elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchMetaDataParser.java
04991fe 
  elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchUtils.java PRE-CREATION

  elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java
d1794fc 
  elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchMetaDataParserTest.java
d7e62e6 

Diff: https://reviews.apache.org/r/26909/diff/


Testing (updated)
-------

Added unittests.

Also accidentally encountered a (unrelated) issue with date values in ElasticSearch. Added
a reproduction unittest with @Ignore (so that it would not block this work). Reported this
other issue here: https://issues.apache.org/jira/browse/METAMODEL-87


Thanks,

Kasper Sørensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message