metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] incubator-metamodel pull request: Added new operators types '>=' a...
Date Thu, 02 Oct 2014 16:33:42 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/incubator-metamodel/pull/3#discussion_r18350367
  
    --- Diff: core/src/main/java/org/apache/metamodel/query/FilterItem.java ---
    @@ -290,34 +272,39 @@ public String toSql(boolean includeSchemaInColumnPaths) {
     
         public static Object appendOperator(StringBuilder sb, Object operand, OperatorType
operator) {
             switch (operator) {
    -        case DIFFERENT_FROM:
    -            sb.append(" <> ");
    -            break;
    -        case EQUALS_TO:
    -            sb.append(" = ");
    -            break;
    -        case LIKE:
    -            sb.append(" LIKE ");
    -            break;
    -        case GREATER_THAN:
    -            sb.append(" > ");
    -            break;
    -        case LESS_THAN:
    -            sb.append(" < ");
    -            break;
    -        case IN:
    -            sb.append(" IN ");
    -            operand = CollectionUtils.toList(operand);
    -            break;
    -        default:
    -            throw new IllegalStateException("Operator could not be determined");
    +            case DIFFERENT_FROM:
    +                sb.append(" <> ");
    +                break;
    +            case EQUALS_TO:
    +                sb.append(" = ");
    +                break;
    +            case LIKE:
    +                sb.append(" LIKE ");
    +                break;
    +            case GREATER_THAN:
    +                sb.append(" > ");
    +                break;
    +            case GREATER_THAN_OR_EQUAL:
    --- End diff --
    
    A lot of line-width/wrapping changes in this class, but I think this switch-statement
has the only semantic change, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message