Mailing-List: contact dev-help@metamodel.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@metamodel.incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of balendrasingh@gmail.com
 designates 209.85.192.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CA+U3tt_Edm8yC_jyqPwixMTnBzBxBxt88vM4dUOWL6hq-mcSig@mail.gmail.com>
References: 
 <CABEwMD4UT-3oLsV0nzidiL6_F+zFLrDHM_AwBUt9hXK1OxUwdQ@mail.gmail.com>
	<CA+U3tt_Edm8yC_jyqPwixMTnBzBxBxt88vM4dUOWL6hq-mcSig@mail.gmail.com>
Date: Wed, 28 May 2014 14:29:51 +0530
Message-ID: 
 <CABEwMD5+459qr5FYt=PAjGgd9p+bs9ep8PeYc4sxK_thiEw4HQ@mail.gmail.com>
Subject: Re: Metamodel timestamp issue for MSSQL
From: Balendra Singh <balendrasingh@gmail.com>
To: dev@metamodel.incubator.apache.org
Content-Type: multipart/alternative; boundary=089e01493f10028b4a04fa72098e

--089e01493f10028b4a04fa72098e
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Yes Kasper.
Already working on it. I will submit the patch soon.


Thanks,
Balendra


On 28 May 2014 14:23, Kasper S=C3=B8rensen <i.am.kasper.sorensen@gmail.com>=
wrote:

> Hi Balendra,
>
> OK thanks for clearing that up.
>
> I suggest we register a bug in JIRA [1] about this and fix it on high
> priority.
> Would you be interested in submitting a patch?
>
> [1] https://issues.apache.org/jira/browse/METAMODEL
>
> Best regards,
> Kasper
>
>
> 2014-05-28 5:57 GMT+02:00 Balendra Singh <balendrasingh@gmail.com>:
>
> > Hi Kasper,
> >
> > We are using *datetime *datatype to store dates in the table.
> >
> >
> >
> > Thanks,
> > Balendra
> >
> >
> > On 27 May 2014 19:24, Kasper S=C3=B8rensen <i.am.kasper.sorensen@gmail.=
com
> > >wrote:
> >
> > > Hi Balendra,
> > >
> > > I think you may have catched a bug that we should look into. Looking
> > > at SQLServerQueryRewriter I don't see any special handling of date/ti=
me
> > > literals in MS SQL, but I do see in the docs for MS SQL server [1]
> that a
> > > number of literals are possible, but none of them complies with the
> > > standard format of MetaModel.
> > >
> > > In addition I looked to one of my favourite SQL dialect comparison
> papers
> > > [2] and it says that timestamp in MS SQL is deprecated and that
> DATETIME
> > > type is preferred. I doubt it has any impact on the query literals, b=
ut
> > > just wondering which type you use?
> > >
> > > Best regards,
> > > Kasper
> > >
> > > [1] http://msdn.microsoft.com/en-us/library/ms710282(v=3Dvs.85).aspx =
and
> > > http://msdn.microsoft.com/en-us/library/ms187819.aspx
> > >
> > > [2]
> http://troels.arvin.dk/db/rdbms/#data_types-date_and_time-timestamp
> > >
> > >
> > > 2014-05-27 12:21 GMT+02:00 Balendra Singh <balendrasingh@gmail.com>:
> > >
> > > > Hi,
> > > >
> > > > I am using the following query in my application. This application =
is
> > > using
> > > > DB2, Postgres, Oracle and MSSQL databases.
> > > > But the following is not being executed in MSSQL saying* Incorrect
> > syntax
> > > > near '2014-05-26 16:02:45'.*
> > > >
> > > > *UPDATE <Table name> SET <column name>=3D? WHERE (<timestamp column=
> <
> > > > TIMESTAMP '2014-05-26 16:02:45')*
> > > >
> > > > I am creating this query using FilterItem.
> > > > After modifying the query with addition of CAST in the query, I am
> able
> > > to
> > > > execute the following query in MSSQL client -
> > > >
> > > > *UPDATE <Table name> SET <column name>=3D? WHERE (<timestamp
> > > > column> < CAST('2014-05-26 16:02:45' AS DATETIME))*
> > > >
> > > > *I debugged the code and found that
> > > > in org.eobjects.metamodel.util.FormatHelper.formatSqlTime(ColumnTyp=
e,
> > > Date,
> > > > boolean, String, String), *we are appending this extra TIMESTAMP
> > > > as typePrefix in the query.
> > > >
> > > > Am I missing something or the Metamodel is not generating query
> > correctly
> > > > compatible for MSSQL.
> > > > Please provide your input.
> > > >
> > > >
> > > >
> > > > Thanks,
> > > > Balendra
> > > >
> > >
> >
>

--089e01493f10028b4a04fa72098e--