Return-Path: X-Original-To: apmail-metamodel-dev-archive@minotaur.apache.org Delivered-To: apmail-metamodel-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3990810420 for ; Thu, 3 Apr 2014 15:43:20 +0000 (UTC) Received: (qmail 87385 invoked by uid 500); 3 Apr 2014 15:16:40 -0000 Delivered-To: apmail-metamodel-dev-archive@metamodel.apache.org Received: (qmail 87323 invoked by uid 500); 3 Apr 2014 15:16:38 -0000 Mailing-List: contact dev-help@metamodel.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.incubator.apache.org Delivered-To: mailing list dev@metamodel.incubator.apache.org Received: (qmail 86634 invoked by uid 99); 3 Apr 2014 15:16:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 15:16:32 +0000 X-ASF-Spam-Status: No, hits=2.5 required=5.0 tests=FREEMAIL_REPLY,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ak.ankitkumar@gmail.com designates 209.85.216.175 as permitted sender) Received: from [209.85.216.175] (HELO mail-qc0-f175.google.com) (209.85.216.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 15:16:26 +0000 Received: by mail-qc0-f175.google.com with SMTP id e16so1981074qcx.6 for ; Thu, 03 Apr 2014 08:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=fyXZU8PRPWRmgePdZyzzPr6/WeCRcdzt7Zni99cfCL0=; b=BnIWx2GB3O5DIBma9ioVXJ+wYnmzutrJ5norugH3Tpo6rQXKImXSUFsykVxK5Ao/8J SOkc4QEOr+WewLPe3Pf6OhGg0pScb9wvV1ilCblinf7E7qriFcAKYjFlRR2NxUcsR+OS mdSHIy0r4TA7y+n58lM4/SXC+OsXXYwiY+pfCOCN/qSYrg9LIIPdsG55EiEdOS0Tx4GK xbiLWY2WcgpLLAH9V2/rmjJRXPNy0fkjeLms/JWpNpqqr8gxcH2sZgZK3epoZr2JK8DC 34zGKzgagXY6FEr6z6VNrtrLHLJW/DTDqgcgBQL7pzjykixwGR1NTClz2SQI6IPaPZO2 buDQ== MIME-Version: 1.0 X-Received: by 10.140.82.167 with SMTP id h36mr7701222qgd.51.1396538166134; Thu, 03 Apr 2014 08:16:06 -0700 (PDT) Received: by 10.229.173.67 with HTTP; Thu, 3 Apr 2014 08:16:06 -0700 (PDT) In-Reply-To: References: <20140331135736.1088.52981@reviews.apache.org> Date: Thu, 3 Apr 2014 17:16:06 +0200 Message-ID: Subject: Re: Review Request 19842: Excel DataContext may break if schema is not loaded at time of executing query From: Ankit Kumar To: dev@metamodel.incubator.apache.org Content-Type: multipart/alternative; boundary=001a11c120ce4ecba504f624e1d8 X-Virus-Checked: Checked by ClamAV on apache.org --001a11c120ce4ecba504f624e1d8 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable +1 Regards Ankit On Tue, Apr 1, 2014 at 9:17 PM, Kasper S=F8rensen < i.am.kasper.sorensen@gmail.com> wrote: > Can anyone please review? > > > 2014-03-31 15:57 GMT+02:00 Kasper S=F8rensen >: > > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/19842/ > > Review request for MetaModel. > > By Kasper S=F8rensen. > > *Bugs: * METAMODEL-47< > https://issues.apache.org/jira/browse/METAMODEL-47> > > *Repository: * metamodel > > Description > > > > Proposed fix for METAMODEL-47 > > > > Testing > > > > Added unittest for this scenario. > > > > Diffs > > > > - > core/src/main/java/org/apache/metamodel/data/RowPublisherDataSet.java > > (8717136) > > - > excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDe= legate.java > > (48a96f3) > > - excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.ja= va > > (f29f86b) > > - > excel/src/main/java/org/apache/metamodel/excel/XlsxSpreadsheetReaderDeleg= ate.java > > (d2e0e98) > > - > excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java > > (010dd03) > > > > View Diff > > > --001a11c120ce4ecba504f624e1d8--