metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ankit Kumar <ak.ankitku...@gmail.com>
Subject Re: Review Request 19842: Excel DataContext may break if schema is not loaded at time of executing query
Date Thu, 03 Apr 2014 15:16:06 GMT
+1

Regards
Ankit


On Tue, Apr 1, 2014 at 9:17 PM, Kasper Sørensen <
i.am.kasper.sorensen@gmail.com> wrote:

> Can anyone please review?
>
>
> 2014-03-31 15:57 GMT+02:00 Kasper Sørensen <i.am.kasper.sorensen@gmail.com
> >:
>
> >    This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/19842/
> >   Review request for MetaModel.
> > By Kasper Sørensen.
> >  *Bugs: * METAMODEL-47<
> https://issues.apache.org/jira/browse/METAMODEL-47>
> >  *Repository: * metamodel
> > Description
> >
> > Proposed fix for METAMODEL-47
> >
> >   Testing
> >
> > Added unittest for this scenario.
> >
> >   Diffs
> >
> >    -
> core/src/main/java/org/apache/metamodel/data/RowPublisherDataSet.java
> >    (8717136)
> >    -
> excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
> >    (48a96f3)
> >    - excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java
> >    (f29f86b)
> >    -
> excel/src/main/java/org/apache/metamodel/excel/XlsxSpreadsheetReaderDelegate.java
> >    (d2e0e98)
> >    -
> excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java
> >    (010dd03)
> >
> > View Diff <https://reviews.apache.org/r/19842/diff/>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message