Return-Path: X-Original-To: apmail-metamodel-dev-archive@minotaur.apache.org Delivered-To: apmail-metamodel-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC18A1034A for ; Wed, 28 Aug 2013 09:12:03 +0000 (UTC) Received: (qmail 53747 invoked by uid 500); 28 Aug 2013 09:12:03 -0000 Delivered-To: apmail-metamodel-dev-archive@metamodel.apache.org Received: (qmail 53683 invoked by uid 500); 28 Aug 2013 09:12:00 -0000 Mailing-List: contact dev-help@metamodel.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.incubator.apache.org Delivered-To: mailing list dev@metamodel.incubator.apache.org Received: (qmail 53659 invoked by uid 99); 28 Aug 2013 09:11:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2013 09:11:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of i.am.kasper.sorensen@gmail.com designates 209.85.219.48 as permitted sender) Received: from [209.85.219.48] (HELO mail-oa0-f48.google.com) (209.85.219.48) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2013 09:11:54 +0000 Received: by mail-oa0-f48.google.com with SMTP id o17so7365771oag.35 for ; Wed, 28 Aug 2013 02:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=0O5Ggy+dBthyeAlISJk5vKlabLcF5IiO/TIMt0FwJwU=; b=SlGJenxu6w7e9uy0HuMOJEjtxUOU5w3tCz8TPSCavb6hvMfYHfxF1KfbwpOwH7Xos3 fTNlFi52wmzprAzivMiPauSuNpkMmh3bthqu4LViMGuQyOZMSyzRbb9Beira+6XNhd3X ofp+rRWOSaR78WOF5EWqbe1s30pfxNUQQ61Y2UBgAdAa5KajvizWaPn+LbvBIDKcWIqD obHJl+eRRbjsSOOzmI2LGlUhUorrW23NcAeis92m0ntNxGMcdfID+RY69503QEfsoLdM siyViOBXJc/UIKmnUjmINw32YL3zBDpI6mBAkcgZPVjepzVayASYU+I2IPO2pOMoVqs+ R1GA== MIME-Version: 1.0 X-Received: by 10.182.81.41 with SMTP id w9mr5685729obx.18.1377681091888; Wed, 28 Aug 2013 02:11:31 -0700 (PDT) Received: by 10.76.144.34 with HTTP; Wed, 28 Aug 2013 02:11:31 -0700 (PDT) Date: Wed, 28 Aug 2013 11:11:31 +0200 Message-ID: Subject: [PATCH] get rid of deprecated "_items" field in DefaultRow From: =?ISO-8859-1?Q?Kasper_S=F8rensen?= To: "dev@metamodel.incubator.apache.org" Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi all, I was debugging some code and ran into a legacy thing in the DefaultRow where we have a deprecated field, "_items". The role of this field has been taken over by the "_header" field which has another type etc., but for backwards compatible deserialization purposes the old "_items" field is still there. So I did a bit of investigation on how to get rid of the field entirely and simply do some conversion on the fly while deserializing legacy objects. And that seems to work nicely actually. I've created a patch and posted it as a Gist here: https://gist.github.com/kaspersorensen/6363895 Any feedback is welcome. And if you agree, can we then add this to the code? Kasper