metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sukhmeet Sethi <sse...@xebia.com>
Subject Re: [PATCH] get rid of deprecated "_items" field in DefaultRow
Date Wed, 28 Aug 2013 09:21:40 GMT
So the logic which you are following is to transform all _items data 
from the stream to _header so we don't need to handle it explicitly.
That looks fine to me.

+1

Regards,
Sukhi

On 8/28/2013 11:11 AM, Kasper Sørensen wrote:
> Hi all,
>
> I was debugging some code and ran into a legacy thing in the
> DefaultRow where we have a deprecated field, "_items". The role of
> this field has been taken over by the "_header" field which has
> another type etc., but for backwards compatible deserialization
> purposes the old "_items" field is still there.
>
> So I did a bit of investigation on how to get rid of the field
> entirely and simply do some conversion on the fly while deserializing
> legacy objects. And that seems to work nicely actually. I've created a
> patch and posted it as a Gist here:
>
> https://gist.github.com/kaspersorensen/6363895
>
> Any feedback is welcome. And if you agree, can we then add this to the code?
>
> Kasper


Mime
View raw message