mesos-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Plan for upgrading protobuf==3.2.0 in Mesos
Date Sat, 27 May 2017 01:01:50 GMT
Thanks Anand and Zhitao!

So I think we can remove the code like below, and switch to use the native
maps supported by proto3, right?
https://github.com/apache/mesos/blob/master/include/mesos/docker/v1.proto#L25:L28

And just curious, if we use the proto2 syntax in each .proto files in
Mesos, is it possible for us to use the new features (like maps) supported
in proto3? And what about the newly introduced .proto file? I think we do
not need to have "syntax = "proto2";" in it, right?


Regards,
Qian Zhang

On Sat, May 27, 2017 at 6:58 AM, Michael Park <mpark@apache.org> wrote:

> Thanks Anand and Zhitao!
>
> On Fri, May 26, 2017 at 3:40 PM Anand Mazumdar <anand@apache.org> wrote:
>
>> We recently committed this [1] and it would be part of the *next major
>> release* (1.4.0). Also, we upgraded to the newer protobuf release 3.3.0.
>>
>>
>> For Mesos developers, this means that we can use proto3 features like
>> arena
>> allocation [2], maps [3] etc. Note that we still need to use the proto2
>> syntax version for backward compatibility.
>>
>> Thanks Zhitao for the contributions!
>>
>> [1] https://issues.apache.org/jira/browse/MESOS-7228
>> [2] https://issues.apache.org/jira/browse/MESOS-5783
>> [3] https://developers.google.com/protocol-buffers/docs/proto#maps
>>
>> -anand
>>
>>
>> On Thu, Apr 27, 2017 at 10:28 AM, Anand Mazumdar <anand@apache.org>
>> wrote:
>>
>> > + dev
>> >
>> > Bumping up the thread to ensure it's not missed.
>> >
>> > -anand
>> >
>> > On Tue, Apr 25, 2017 at 11:01 AM, Zhitao Li <zhitaoli.cs@gmail.com>
>> wrote:
>> > > Dear framework owners and users,
>> > >
>> > > We are working on upgrading the protobuf library in Mesos to 3.2.0 in
>> > > https://issues.apache.org/jira/browse/MESOS-7228, to overcome some
>> > protobuf
>> > > limitation on message size as well as preparing for further
>> improvement.
>> > We
>> > > aim to release this with the upcoming Mesos 1.3.0.
>> > >
>> > > Because we upgraded the protoc compiler in this process, all generated
>> > java
>> > > and python code may not be compatible with protobuf 2.6.1 (the
>> previous
>> > > dependency), and we ask you to upgrade the protobuf dependency to
>> 3.2.0
>> > when
>> > > you upgrade your framework dependency to 1.3.0.
>> > >
>> > > For java, a snapshot maven artifact has been prepared (by Anand
>> > Mazumdar's
>> > > courtesy) at
>> > > https://repository.apache.org/content/repositories/
>> > snapshots/org/apache/mesos/mesos/1.3.0-SNAPSHOT/
>> > > . Please feel free to play out with it and let us know if you run into
>> > any
>> > > issues.
>> > >
>> > > Note that the binary upgrade process should still be compatible: any
>> > java or
>> > > based framework (scheduler or executor) should still work out of box
>> with
>> > > Mesos 1.3.0 once released. It is suggested to get your cluster
>> upgraded
>> > to
>> > > 1.3.0 first, then come back and upgrade your executors and schedulers.
>> > >
>> > > We understand this may expose inconvenience around updating the
>> protobuf
>> > > dependency, so please let us know if you have any concern or further
>> > > questions.
>> > >
>> > > --
>> > >
>> > > Cheers,
>> > >
>> > > Zhitao Li and Anand Mazumdar,
>> >
>>
>

Mime
View raw message