mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <>
Subject Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Date Fri, 10 Jan 2020 01:37:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 10, 2020, 1:37 a.m.)

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Cleaned up implementation to always return the correct length for unix addresses.

Repository: mesos


Address handling code for unix domain sockets assumed that
strlen() could be used to compute the name of a unix domain
socket, but that fails for unnamed sockets or in the case
where an abstract domain socket contains embedded null bytes.

This patch adds a new `length` parameter to correctly handle
these special cases.

Diffs (updated)

  3rdparty/libprocess/include/process/address.hpp 749498056b52b916dfaf6c85f83ecc05e0d5406c

  3rdparty/libprocess/include/process/network.hpp 8f48a4a78557309a9b1b00d7defb45eed454b077




Ran existing unit tests and verified that the newly added `CHECK()` doesn't trigger.


Benno Evers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message