mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71790: SSL Socket: Implemented sendfile.
Date Wed, 20 Nov 2019 00:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71790/
-----------------------------------------------------------

(Updated Nov. 19, 2019, 4:29 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Changes
-------

Rebase on top of compute_thread and shutdown changes.


Bugs: MESOS-10010
    https://issues.apache.org/jira/browse/MESOS-10010


Repository: mesos


Description
-------

This implements the SSL socket's sendfile method, which must read
the file (unlike the zero-copy os::sendfile).

This also moves a test exercising sendfile from process_tests.cpp
into http_tests.cpp and parameterizes it for SSL and non-SSL.


Diffs (updated)
-----

  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 1433f3d09a72133fab1441be53562d508bc01682 
  3rdparty/libprocess/src/tests/process_tests.cpp 05dc5ec2fdc74a989689e4378bef775bcf2b7a87



Diff: https://reviews.apache.org/r/71790/diff/2/

Changes: https://reviews.apache.org/r/71790/diff/1-2/


Testing
-------

cmake --build . --target libprocess-tests
libprocess-tests


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message