From reviews-return-83365-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Nov 8 19:32:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66DC2180671 for ; Thu, 8 Nov 2018 19:32:28 +0100 (CET) Received: (qmail 71714 invoked by uid 500); 8 Nov 2018 18:32:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 71703 invoked by uid 99); 8 Nov 2018 18:32:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2018 18:32:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6027A1812B6; Thu, 8 Nov 2018 18:32:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wk953I83E8MH; Thu, 8 Nov 2018 18:32:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DE0A977236; Thu, 8 Nov 2018 15:35:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 401DDE006D; Thu, 8 Nov 2018 15:35:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2AFC1C402E0; Thu, 8 Nov 2018 15:35:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5636622517960174823==" MIME-Version: 1.0 Subject: Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher. From: Mesos Reviewbot Windows To: Jie Yu , Qian Zhang , James Peach Cc: Mesos Reviewbot Windows , Andrei Budnik , mesos Date: Thu, 08 Nov 2018 15:35:08 -0000 Message-ID: <20181108153508.57075.69827@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68022/ X-Sender: Mesos Reviewbot Windows References: <20180806133934.12236.30193@reviews-vm2.apache.org> In-Reply-To: <20180806133934.12236.30193@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============5636622517960174823== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review210417 ----------------------------------------------------------- FAIL: Failed to apply the dependent review: 67844. Failed command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2584/mesos-review-68022 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2584/mesos-review-68022/logs/apply-review-67844.log): ``` error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz' error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz' error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply ``` - Mesos Reviewbot Windows On Aug. 6, 2018, 1:39 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68022/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 1:39 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9106 > https://issues.apache.org/jira/browse/MESOS-9106 > > > Repository: mesos > > > Description > ------- > > Containerizer launcher creates an instance of `SeccompFilter`, which is > used to setup Seccomp profile using `ContainerSeccompProfile` message > prepared by the `linux/seccomp` isolator. The Seccomp filter is loaded > right before calling `execve()`, so that a container will be running > with a syscall filtering enabled. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2 > > > Diff: https://reviews.apache.org/r/68022/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > > --===============5636622517960174823==--