From reviews-return-81328-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Aug 23 02:32:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E829D180662 for ; Thu, 23 Aug 2018 02:32:21 +0200 (CEST) Received: (qmail 59656 invoked by uid 500); 23 Aug 2018 00:32:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 59645 invoked by uid 99); 23 Aug 2018 00:32:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2018 00:32:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0658F1810B9; Thu, 23 Aug 2018 00:32:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id UIBYejHnnJ50; Thu, 23 Aug 2018 00:32:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D41BC5F1F0; Thu, 23 Aug 2018 00:32:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71C93E0110; Thu, 23 Aug 2018 00:32:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E0F22C404FA; Thu, 23 Aug 2018 00:32:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7951554906111496570==" MIME-Version: 1.0 Subject: Re: Review Request 68366: Added agent protected port range option in network isolator. From: Xudong Ni via Review Board To: James Peach Cc: Xudong Ni , Mesos Reviewbot , mesos , Mesos Reviewbot Windows Date: Thu, 23 Aug 2018 00:32:16 -0000 Message-ID: <20180823003216.5559.11284@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Xudong Ni X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68366/ X-Sender: Xudong Ni References: <20180822235058.5559.47892@reviews-vm2.apache.org> In-Reply-To: <20180822235058.5559.47892@reviews-vm2.apache.org> Reply-To: Xudong Ni X-ReviewRequest-Repository: mesos --===============7951554906111496570== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 22, 2018, 11:50 p.m., James Peach wrote: > > I think this change broke the `NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource` test, just regressing against master. Fixed it; There was an empty ports condition removed in one of iteration but didn't add back in the later iterations - Xudong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207781 ----------------------------------------------------------- On Aug. 22, 2018, 5:35 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68366/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 5:35 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-9133 > https://issues.apache.org/jira/browse/MESOS-9133 > > > Repository: mesos > > > Description > ------- > > For a network isolator disabled environment, in practice, there could > be a lot of users already binding to ephemeral ports; It would take > a lot of efforts to find/notify/modify those apps; In order to take > advantage of network isolator and enable it in such system, it would > be useful to add mesos-agent configuration option to allow enforce > port isolation in only the specified certain port range > > > Diffs > ----- > > docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e > docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768 > src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8 > src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9 > src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f > src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b > src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884 > > > Diff: https://reviews.apache.org/r/68366/diff/6/ > > > Testing > ------- > > New test added to test feature: > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementProtectedPort (1886 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1887 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1900 ms total) > [ PASSED ] 1 test. > > Existing test updated to test the negative cases: > > [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (58 ms) > [----------] 1 test from NetworkPortsIsolatorTest (58 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (69 ms total) > [ PASSED ] 1 test. > > Existing test for isolator feature: > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1992 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1993 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (2004 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Xudong Ni > > --===============7951554906111496570==--