mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.
Date Thu, 21 Jun 2018 07:56:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/#review205158
-----------------------------------------------------------



PASS: Mesos patch 67615 was successfully built and tested.

Reviews applied: `['67561', '67615']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67615

- Mesos Reviewbot Windows


On June 21, 2018, 4:56 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67615/
> -----------------------------------------------------------
> 
> (Updated June 21, 2018, 4:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, Kapil Arya, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently `createStrippedScalarQuantity()` strips resource meta-data
> except revocable and turns dynamic reservation into static reservation.
> However, no current code depends on this behavior and this leads to
> boilerplate code around call sites and performance overhead.
> 
> This patch further clears the above meta-data for simplicity
> and performance.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp bd6d6d61a8637ecb3ababaf7247b5fc49cc8b070 
>   include/mesos/v1/resources.hpp c065dd16e7723ef093a8e58841495e2bd47ce9d8 
>   src/common/resources.cpp b9f1c2ddbcd09ae1a1ab2caf9856d1fb9a589e89 
>   src/master/allocator/mesos/hierarchical.cpp f631ce73d578a313dfdacf1ee97737dde90ae8f8

>   src/tests/resources_tests.cpp 14104239da7dec2aa6d6e78777249c69bd019a6d 
>   src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d 
>   src/v1/resources.cpp 3d06fc64a19ab57d2af5fb465d3dc06ba79afcc5 
> 
> 
> Diff: https://reviews.apache.org/r/67615/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message