mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 66919: Failure to update registry should abort the master process.
Date Mon, 07 May 2018 17:20:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66919/
-----------------------------------------------------------

(Updated May 7, 2018, 5:20 p.m.)


Review request for mesos, Joseph Wu and Jiang Yan Xu.


Bugs: MESOS-8630
    https://issues.apache.org/jira/browse/MESOS-8630


Repository: mesos


Description (updated)
-------

When the registrar fails to update the registry it would abort the
actor and fail all future operations,However when the registrar
updates is requested by an operator API such as maintenance update,
the master process doesn't shut down (a 500 error is returned to the
client instead)and all subsequent operations will fail.

Review: https://reviews.apache.org/r/66919


Diffs (updated)
-----

  src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad 


Diff: https://reviews.apache.org/r/66919/diff/3/

Changes: https://reviews.apache.org/r/66919/diff/2-3/


Testing
-------

No error found by running all unit tests(make check)


Thanks,

Xudong Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message