From reviews-return-75808-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Sat Apr 7 02:14:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D14B9180649 for ; Sat, 7 Apr 2018 02:14:32 +0200 (CEST) Received: (qmail 61459 invoked by uid 500); 7 Apr 2018 00:14:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61444 invoked by uid 99); 7 Apr 2018 00:14:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Apr 2018 00:14:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DE86618077D; Sat, 7 Apr 2018 00:14:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.441 X-Spam-Level: ** X-Spam-Status: No, score=2.441 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, MANY_SPAN_IN_TEXT=1, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01, URI_NOVOWEL=0.5] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TnvK30mgYyoG; Sat, 7 Apr 2018 00:14:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E5A135FAEC; Sat, 7 Apr 2018 00:14:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8327DE002F; Sat, 7 Apr 2018 00:14:26 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 65D18C40720; Sat, 7 Apr 2018 00:14:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2144880271521867712==" MIME-Version: 1.0 Subject: Re: Review Request 66445: Windows: Cleaned up included CRT headers. From: Mesos Reviewbot Windows To: Akash Gupta , Eric Mumau , John Kordich , Joseph Wu , Michael Park Cc: Mesos Reviewbot Windows , Andrew Schwartzmeyer , mesos Date: Sat, 07 Apr 2018 00:14:26 -0000 Message-ID: <20180407001426.23495.20229@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66445/ X-Sender: Mesos Reviewbot Windows References: <20180406231802.41339.80358@reviews-vm2.apache.org> In-Reply-To: <20180406231802.41339.80358@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/windows/open.hpp Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============2144880271521867712== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200688 ----------------------------------------------------------- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', '66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', '66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', '66445']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (125 ms) [----------] 9 tests from Endpoint/SlaveEndpointTest (1107 ms total) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms total) [----------] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (775 ms) [----------] 1 test from IsolationFlag/CpuIsolatorTest (801 ms total) [----------] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (842 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (867 ms total) [----------] Global test environment tear-down [==========] 954 tests from 94 test cases ran. (467793 ms total) [ PASSED ] 953 tests. [ FAILED ] 1 test, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout 1 FAILED TEST YOU HAVE 214 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445/logs/mesos-tests-stderr.log): ``` I0407 00:14:09.339630 15772 master.cpp:10452] Updating the state of task 581ca225-d5be-4a9d-bd24-16c0730a05b7 of framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED) I0407 00:14:09.339630 14372 slave.cpp:3973] Shutting down framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 I0407 00:14:09.339630 14372 slave.cpp:6670] Shutting down executor '581ca225-d5be-4a9d-bd24-16c0730a05b7' of framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 at executor(1)@10.3.1.8:65408 I0407 00:14:09.340621 14372 slave.cpp:923] Agent terminating W0407 00:14:09.340621 14372 slavI0407 00:14:09.146625 16972 exec.cpp:162] Version: 1.6.0 I0407 00:14:09.175635 4452 exec.cpp:236] Executor registered on agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 I0407 00:14:09.180619 17520 executor.cpp:177] Received SUBSCRIBED event I0407 00:14:09.185617 17520 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0407 00:14:09.185617 17520 executor.cpp:177] Received LAUNCH event I0407 00:14:09.190620 17520 executor.cpp:649] Starting task 581ca225-d5be-4a9d-bd24-16c0730a05b7 I0407 00:14:09.279657 17520 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0407 00:14:09.309659 17520 executor.cpp:662] Forked command at 19044 I0407 00:14:09.341650 11320 exec.cpp:445] Executor asked to shutdown I0407 00:14:09.341650 15288 executor.cpp:177] Received SHUTDOWN event I0407 00:14:09.341650 15288 executor.cpp:759] Shutting down I0407 00:14:09.341650 15288 executor.cpp:869] Sending SIGTERM to process tree at pid e.cpp:3969] Ignoring shutdown framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 because it is terminating I0407 00:14:09.342628 15772 master.cpp:10551] Removing task 581ca225-d5be-4a9d-bd24-16c0730a05b7 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 on agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 at slave(423)@10.3.1.8:65387 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0407 00:14:09.344620 15216 containerizer.cpp:2338] Destroying container 1f11ebaf-3035-46f8-ac1f-eaf3dc6d0059 in RUNNING state I0407 00:14:09.344620 15216 containerizer.cpp:2952] Transitioning the state of container 1f11ebaf-3035-46f8-ac1f-eaf3dc6d0059 from RUNNING to DESTROYING I0407 00:14:09.345892 15772 master.cpp:1295] Agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 at slave(423)@10.3.1.8:65387 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected I0407 00:14:09.345892 15772 master.cpp:3286] Disconnecting agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 at slave(423)@10.3.1.8:65387 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0407 00:14:09.345892 13776 hierarchical.cpp:344] Removed framework 5f5619de-7136-40e9-a80d-ac18a89509a6-0000 I0407 00:14:09.345892 15216 launcher.cpp:156] Asked to destroy container 1f11ebaf-3035-46f8-ac1f-eaf3dc6d0059 I0407 00:14:09.346639 15772 master.cpp:3305] Deactivating agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 at slave(423)@10.3.1.8:65387 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0407 00:14:09.346639 14372 hierarchical.cpp:766] Agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 deactivated I0407 00:14:09.440850 2980 containerizer.cpp:2791] Container 1f11ebaf-3035-46f8-ac1f-eaf3dc6d0059 has exited I0407 00:14:09.472859 18740 master.cpp:1137] Master terminating I0407 00:14:09.475013 15216 hierarchical.cpp:609] Removed agent 5f5619de-7136-40e9-a80d-ac18a89509a6-S0 I0407 00:14:09.917861 17076 process.cpp:929] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 6, 2018, 11:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66445/ > ----------------------------------------------------------- > > (Updated April 6, 2018, 11:18 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8759 > https://issues.apache.org/jira/browse/MESOS-8759 > > > Repository: mesos > > > Description > ------- > > The set `errno` value in `os::kill()` is never checked (especially on > Windows), so `_set_errno()` and thus `errno.h` were removed. > > The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged > in `open.hpp`, not `windows.hpp`. > > The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h` > were no longer used or needed as the respective CRT APIs were > replaced. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/kill.hpp 9cec1117fac3cf6bd624fc7db524ef1ad10cd55d > 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 9181429383a991fe2b87701d2bfd0e858ac2537b > 3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/rmdir.hpp a2926dab2c8e219cf5938c4df27f83488198dd6b > 3rdparty/stout/include/stout/os/windows/sendfile.hpp fff5872db6b3f69464e41e6d108a107e4eeabd12 > 3rdparty/stout/include/stout/windows.hpp 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 > 3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 > 3rdparty/stout/include/stout/windows/os.hpp 900baf9be4e3089cb43e444b14b155a80bcd1591 > > > Diff: https://reviews.apache.org/r/66445/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============2144880271521867712==--