From reviews-return-75779-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Fri Apr 6 15:38:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B595A180675 for ; Fri, 6 Apr 2018 15:38:06 +0200 (CEST) Received: (qmail 64200 invoked by uid 500); 6 Apr 2018 13:38:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63396 invoked by uid 99); 6 Apr 2018 13:38:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2018 13:38:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4D9E118074A; Fri, 6 Apr 2018 13:38:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YDd4AJKErZ5A; Fri, 6 Apr 2018 13:38:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 407315F666; Fri, 6 Apr 2018 13:38:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C1D5E0117; Fri, 6 Apr 2018 13:38:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4D3C6C40619; Fri, 6 Apr 2018 13:38:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0360637712137273769==" MIME-Version: 1.0 Subject: Re: Review Request 66165: Re-fixed many master allocator tests. From: Mesos Reviewbot Windows To: Benjamin Bannier , Alexander Rukletsov Cc: Mesos Reviewbot Windows , Till Toenshoff , mesos Date: Fri, 06 Apr 2018 13:38:00 -0000 Message-ID: <20180406133800.23495.44335@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66165/ X-Sender: Mesos Reviewbot Windows References: <20180320203633.25996.16254@reviews-vm2.apache.org> In-Reply-To: <20180320203633.25996.16254@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============0360637712137273769== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review200644 ----------------------------------------------------------- PASS: Mesos patch 66165 was successfully built and tested. Reviews applied: `['66164', '66165']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66165 - Mesos Reviewbot Windows On March 20, 2018, 8:36 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66165/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 8:36 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-8613 > https://issues.apache.org/jira/browse/MESOS-8613 > > > Repository: mesos > > > Description > ------- > > When the slave has a very short lifetime, its scheduled registration > retry might occur when the test is tearing down. These unintuitively > motivated registrations in turn cause additional invocations of > `AddSlave` on the allocator. > Additionally, this also reverts the newly introduced Clock pauses as > they have shown to be problematic. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp 1ceb8e8a57ab300a957931d5ad3d54904e555597 > > > Diff: https://reviews.apache.org/r/66165/diff/2/ > > > Testing > ------- > > make check > > Ran the MasterAllocatorTests 10k times without any hiccups. > > > Thanks, > > Till Toenshoff > > --===============0360637712137273769==--