mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.
Date Thu, 12 Apr 2018 09:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66546/
-----------------------------------------------------------

(Updated April 12, 2018, 11:48 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Fixed a close comment typo.


Bugs: MESOS-7558
    https://issues.apache.org/jira/browse/MESOS-7558


Repository: mesos


Description
-------

This patch adds a check to the resource provider manager's subscribe
functionality making sure that any the ID sent by a resubscribing
resource provider corresponds to some previously known resource
provider.

This not only serves as convenient validation of user-provided data,
but also makes sure that the internal state of the resource provider
manager remains consistent.


Diffs (updated)
-----

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66546/diff/3/

Changes: https://reviews.apache.org/r/66546/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message