mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`.
Date Sun, 08 Apr 2018 00:50:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/
-----------------------------------------------------------

(Updated April 7, 2018, 5:50 p.m.)


Review request for mesos, Andrew Schwartzmeyer and James Peach.


Repository: mesos


Description (updated)
-------

This avoids unix's assumption that `pid_t` is a signed integer (which is
not the case on Windows) and explicitly shows whether a pid has been
assigned from launching.

We also changed argument name in `reaped` method to `_pid` to avoid
shadowing.


Diffs (updated)
-----

  src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 


Diff: https://reviews.apache.org/r/66481/diff/2/

Changes: https://reviews.apache.org/r/66481/diff/1-2/


Testing
-------

`make` on Linux.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message