mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.
Date Fri, 06 Apr 2018 00:03:20 GMT


> On April 5, 2018, 4:58 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/os/posix/stat.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/66435/diff/1/?file=1992280#file1992280line66>
> >
> >     Did you mean `const int_fd& fd`?

Not on POSIX, it's just an `int`.


> On April 5, 2018, 4:58 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/os/posix/stat.hpp
> > Lines 99-101 (patched)
> > <https://reviews.apache.org/r/66435/diff/1/?file=1992280#file1992280line99>
> >
> >     Ditto on `const int_fd& fd`

Ditto.


> On April 5, 2018, 4:58 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/os/posix/stat.hpp
> > Lines 133 (patched)
> > <https://reviews.apache.org/r/66435/diff/1/?file=1992280#file1992280line133>
> >
> >     Ditto on `const int_fd& fd`

Ditto.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66435/#review200603
-----------------------------------------------------------


On April 3, 2018, 10:52 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66435/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 10:52 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-8682
>     https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These should be refactored to share the common code, and the
> additional overloads added to the other APIs too. However, it is not
> currently necessary, and would go unused.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/stat.hpp 58353742b39bac4fbfcb2ab7708f0f8719ea5b3b

>   3rdparty/stout/include/stout/os/windows/stat.hpp c04953ee42f45dd80b6362fbeeddf4a0a20e7412

> 
> 
> Diff: https://reviews.apache.org/r/66435/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message