mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 66323: Added tests for failed task launch on agent.
Date Thu, 05 Apr 2018 19:10:39 GMT


> On April 3, 2018, 5:17 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5251-5252 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5251>
> >
> >     Is this needed?
> 
> Meng Zhu wrote:
>     To avoid uninteresting mock calls.
> 
> Greg Mann wrote:
>     The real question here is WHY does this method get called on the scheduler? The `failure()`
method is invoked whenever an `Event::FAILURE` is received by the test v1 scheduler. I didn't
realize it, but it turns out we evolve the `ExitedExecutorMessage` into an `Event::FAILURE`
for v1 schedulers: https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/internal/evolve.cpp#L294-L305
>     
>     So the exiting executor in this test explains why that method is invoked. However,
I don't understand why it would be invoked twice, since we only have one executor here? I
wonder if we're executing some cleanup logic for the failed task twice? It's also possible
that the event is sent when the agent is removed at the end of the test, but I don't recall
running into this in other tests.

Changed to `atmost(1)`


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------


On April 3, 2018, 8:32 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 8:32 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66323/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message