mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
Date Tue, 03 Apr 2018 19:13:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66404/#review200392
-----------------------------------------------------------


Ship it!




LGTM, before landing this patch, could we verify the nested cgroup is alwasy supportted after
kernel 2.6.23?

- Gilbert Song


On April 3, 2018, 9:19 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66404/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 9:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
>     https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we were checking for nested cgroup support while trying to
> create a linux launcher. This was necessary to make sure that the
> kernel supports creating nested cgroups. As we don't support old
> kernel versions which don't support nested cgroups, this check can be
> safely removed.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 
> 
> 
> Diff: https://reviews.apache.org/r/66404/diff/1/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message