From reviews-return-75079-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Mar 21 21:17:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 969D2180651 for ; Wed, 21 Mar 2018 21:17:11 +0100 (CET) Received: (qmail 62132 invoked by uid 500); 21 Mar 2018 20:17:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62110 invoked by uid 99); 21 Mar 2018 20:17:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 20:17:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9AE801A0975; Wed, 21 Mar 2018 20:17:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.19 X-Spam-Level: * X-Spam-Status: No, score=1.19 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zuabtHaywXHM; Wed, 21 Mar 2018 20:17:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2EDA45FDC3; Wed, 21 Mar 2018 20:17:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1831E0253; Wed, 21 Mar 2018 20:17:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4D727C407C0; Wed, 21 Mar 2018 20:17:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2067020265186296513==" MIME-Version: 1.0 Subject: Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. From: Greg Mann To: Chun-Hung Hsiao , Greg Mann Cc: Meng Zhu , mesos Date: Wed, 21 Mar 2018 20:17:06 -0000 Message-ID: <20180321201706.64105.21215@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66126/ X-Sender: Greg Mann References: <20180319184303.52219.39937@reviews-vm2.apache.org> In-Reply-To: <20180319184303.52219.39937@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============2067020265186296513== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199699 ----------------------------------------------------------- src/tests/slave_tests.cpp Lines 4698-4703 (original), 4696-4701 (patched) Indented too far. - Greg Mann On March 19, 2018, 6:43 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66126/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 6:43 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > This helps to encapsulate a task launch into a single > future which will come in handy when enforcing the task > launch order. > > This patch also consolidated the error handling code > in the task launch path. > > Affected tests are also updated. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 > src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd > src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 > src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 > > > Diff: https://reviews.apache.org/r/66126/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > > --===============2067020265186296513==--